Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: setup: avoid host name collisions ......................................................................
packaging: setup: avoid host name collisions Doesn't save OVEHOSTED_ENGINE/appHostName in answer file anymore, avoiding to use that again on additional host. Propose as default hosted_engine_<host id> instead of local_host, ensuring different defaults on additional hosts. Change-Id: Ide57aa8d88729296b9911a196bbf16357abbe70c Reported-By: Oved Ourfalli <[email protected]> Signed-off-by: Sandro Bonazzola <[email protected]> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup refs/changes/43/18143/1 diff --git a/src/ovirt_hosted_engine_setup/constants.py b/src/ovirt_hosted_engine_setup/constants.py index 46339f7..4cdce0d 100644 --- a/src/ovirt_hosted_engine_setup/constants.py +++ b/src/ovirt_hosted_engine_setup/constants.py @@ -258,7 +258,6 @@ @ohostedattrs( summary=True, description=_('Host name for web application'), - answerfile=True, ) def APP_HOST_NAME(self): return 'OVEHOSTED_ENGINE/appHostName' diff --git a/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py b/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py index fc39a52..1d7fee2 100644 --- a/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py +++ b/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py @@ -204,7 +204,9 @@ ' inside the Administrator Portal [@DEFAULT@]: ' ), prompt=True, - default='local_host', + default='hosted_engine_%s' % self.environment[ + ohostedcons.StorageEnv.HOST_ID + ], ) if hostname: self.environment[ -- To view, visit http://gerrit.ovirt.org/18143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide57aa8d88729296b9911a196bbf16357abbe70c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
