Yair Zaslavsky has posted comments on this change. Change subject: core: Database functions not fully optimized ......................................................................
Patch Set 1: (2 comments) .................................................... File packaging/dbscripts/common_sp.sql Line 197: -------------------------------------------------- Line 198: -- End of DB helper functions Line 199: -------------------------------------------------- Line 200: Line 201: CREATE OR REPLACE FUNCTION isloggingenabled(errorcode text) Agreed, should be done in a separate patch. Line 202: RETURNS boolean STABLE AS Line 203: $BODY$ Line 204: -- determine if logging errors is enabled. Line 205: -- define in your postgresql.conf: .................................................... File packaging/dbscripts/create_functions.sql Line 12: CREATE TYPE booleanResultType AS(result BOOLEAN); Line 13: Line 14: Line 15: CREATE OR REPLACE FUNCTION getGlobalIds(v_name VARCHAR(4000)) Line 16: RETURNS UUID IMMUTABLE not sure i understood your comment here. Line 17: AS $function$ Line 18: DECLARE Line 19: v_id UUID; Line 20: BEGIN -- To view, visit http://gerrit.ovirt.org/17962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29a355286f5e6c23afe64c63efefe311c65be581 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
