Michal Skrivanek has posted comments on this change.

Change subject: engine: Display type validation
......................................................................


Patch Set 1: Code-Review-1

I'd suggest to wait/sync with review 16700 and solve this in a similar fashion 
as 17964. I.e. osinfo has list of supported consoles and you are only showing 
those in the Edit VM dialog.
Then the logic and error message of this patch is not needed.

-- 
To view, visit http://gerrit.ovirt.org/18150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifff508fb2cbc3b2447f6fb7412d4feadd20a3c6e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to