Arik Hadas has posted comments on this change.
Change subject: core: fix NPE on add vm template ctor
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 475: @Override
Line 476: protected void endSuccessfully() {
Line 477: setVmTemplateId(getParameters().getVmTemplateId());
Line 478: setVmId(getVmIdFromImageParameters());
Line 479: isVmInDb = getVm() != null;
right, I missed it. we really should separate the different use-cases to
different flows...
Line 480:
Line 481: getVmStaticDAO().incrementDbGeneration(getVmTemplateId());
Line 482: for (VdcActionParametersBase p :
getParameters().getImagesParameters()) {
Line 483:
Backend.getInstance().EndAction(VdcActionType.CreateImageTemplate, p);
--
To view, visit http://gerrit.ovirt.org/18144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b870a89c337a47110aaa7d20d027ad8ef06cfe8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
