Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: configure pghba for use as postgres
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
....................................................
File packaging/ovirt-engine-dwh-setup.py
Line 253: logging.debug("starting main()")
Line 254:
Line 255: db_dict = getDbDictFromOptions()
Line 256: if not os.path.exists(DIR_DATABASE_DWH_CONFIG):
Line 257: os.makedirs(DIR_DATABASE_DWH_CONFIG, 0644)
Are you sure you want 0644 with makedirs? if you try to do
os.makedirs('/tmp/a/b', 0644) it will fail creating b because it can't access a
directory.
Line 258: with open(FILE_DATABASE_DWH_CONFIG, 'w') as fdwh:
Line 259: fdwh.write(
Line 260: (
Line 261: 'DWH_USER={user}\n'
--
To view, visit http://gerrit.ovirt.org/18036
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7244d9ec7a6b2dc4dbc2c3965b1f26e4b51b66ca
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
