Sergey Gotliv has posted comments on this change.
Change subject: core: InitVdsOnUp - proceed regardless of problematic
iso/export domain
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 273: log.errorFormat("Storage Domain {0} of pool {1} is in
problem in host {1}",
Line 274: domainInfo != null ?
domainInfo.getStorageName() : domainId,
Line 275: getVds().getName(),
Line 276: getStoragePool()
Line 277: .getName());
Please, revise this log message again, it seems to be mismatch - pool and host
marked with {1} but host parameter is indeed 1 while pool probably has to be 2.
Line 278: if (domainInfo == null ||
domainInfo.getStorageDomainType().isDataDomain()) {
Line 279: returnValue = false;
Line 280: }
Line 281: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
Line 554:
Line 555: public StorageDomainStaticDAO getStorageDomainStaticDAO() {
Line 556: return getDbFacade().getStorageDomainStaticDao();
Line 557: }
Line 558:
This remark is not related to patch, but I am wondering if all these DAOs
really have to reside in AuditLogableBase...
Line 559: public StoragePoolDAO getStoragePoolDAO() {
Line 560: return getDbFacade().getStoragePoolDao();
Line 561: }
Line 562:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 95: proxy.UpdateVdsDomainsData(vdsId, vdsName, vdsDomainData);
Line 96: }
Line 97: }
Line 98:
Line 99: public static List<Guid> checkIfDomainsReportedAsProblematic(Guid
storagePoolId, List<VDSDomainsData> vdsDomainsData) {
Get is really sounds like a getter, but this is not "checkIf" either. Can it be
"fetch" or "retrieve"? I am not insist :-)
Line 100: IrsProxyData proxy = _irsProxyData.get(storagePoolId);
Line 101: if (proxy != null) {
Line 102: return
proxy.checkIfDomainsReportedAsProblematic(vdsDomainsData);
Line 103: }
--
To view, visit http://gerrit.ovirt.org/17986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32372aa80d7193a814f2500231d4545d2b1a5fc3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
