Allon Mureinik has posted comments on this change.

Change subject: backend: [wip] add ActionGroup to access image domains
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java
Line 134:     @Override
Line 135:     public List<PermissionSubject> getPermissionCheckSubjects() {
Line 136:         List<PermissionSubject> permissionSubjects = new 
ArrayList<>();
Line 137:         permissionSubjects.add(new 
PermissionSubject(getDiskImage().getId(),
Line 138:                 VdcObjectType.Disk, ActionGroup.ATTACH_DISK));
ack, my mistake.
Line 139:         permissionSubjects.add(new 
PermissionSubject(getParameters().getStorageDomainId(),
Line 140:                 VdcObjectType.Storage, ActionGroup.CREATE_DISK)); // 
ActionGroup.ACCESS_IMAGE_STORAGE ?
Line 141:         return permissionSubjects;
Line 142:     }


-- 
To view, visit http://gerrit.ovirt.org/18078
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff053962ae1dceef51c7d8ff356fcf527aa5e2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to