Daniel Erez has uploaded a new change for review. Change subject: webadmin: filtering hosts on remove storage dialog ......................................................................
webadmin: filtering hosts on remove storage dialog Using GetHostsForStorageOperation query (introduced in [1]) for filtering hosts on remove storage domain dialog. [1] http://gerrit.ovirt.org/15397 Change-Id: I5ef16a5972450ebf5f1659524535aaa7f26ee502 Bug-Url: https://bugzilla.redhat.com/991081 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/18235/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java index 336c6b3..e097856 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java @@ -26,7 +26,6 @@ import org.ovirt.engine.core.common.businessentities.StorageServerConnections; import org.ovirt.engine.core.common.businessentities.StorageType; import org.ovirt.engine.core.common.businessentities.VDS; -import org.ovirt.engine.core.common.businessentities.VDSStatus; import org.ovirt.engine.core.common.interfaces.SearchType; import org.ovirt.engine.core.common.mode.ApplicationMode; import org.ovirt.engine.core.common.queries.SearchParameters; @@ -786,7 +785,10 @@ model.setMessage(ConstantsManager.getInstance().getConstants().areYouSureYouWantToRemoveTheStorageDomainMsg()); model.getFormat().setIsAvailable(false); - AsyncDataProvider.getHostListByStatus(new AsyncQuery(new Object[]{this, model}, new INewAsyncCallback() { + StorageDomain storage = (StorageDomain) getSelectedItem(); + boolean localFsOnly = storage.getStorageType() == StorageType.LOCALFS; + + AsyncDataProvider.getHostsForStorageOperation(new AsyncQuery(new Object[]{this, model}, new INewAsyncCallback() { @Override public void onSuccess(Object target, Object returnValue) { @@ -816,7 +818,7 @@ } } - }), VDSStatus.Up); + }), null, localFsOnly); } private void onRemove() -- To view, visit http://gerrit.ovirt.org/18235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ef16a5972450ebf5f1659524535aaa7f26ee502 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
