Tal Nisan has posted comments on this change.
Change subject: core: Remove member init in the action parameters
......................................................................
Patch Set 1:
(4 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddBondParameters.java
Line 42:
Line 43: public AddBondParameters(Guid vdsId, String bondName, Network
network, String[] nics, int vladId) {
Line 44: this(vdsId, bondName, network, nics);
Line 45: setVlanId(vladId);
Line 46: privateBootProtocol = NetworkBootProtocol.NONE;
Redundant, the call to this(vdsId, bondName, network, nics) already handles it
Line 47: }
Line 48:
Line 49: public String[] getNics() {
Line 50: return nics == null ? new String[0] : nics;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java
Line 27: public ImagesActionsParametersBase(Guid imageId) {
Line 28: super(Guid.Empty);
Line 29: setEntityInfo(new EntityInfo(VdcObjectType.Disk, imageId));
Line 30: this.imageId = imageId;
Line 31: imageGroupID = Guid.Empty;
Don't we need destinationImageId = Guid.Empty here also?
Line 32: }
Line 33:
Line 34: public Guid getImageId() {
Line 35: return imageId;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java
Line 16
Line 17
Line 18
Line 19
Line 20
Clearly this is a redundant line but I guess the original meaning was
this.containerId = containerId, maybe we should check if we should add it
correctly instead of removing it?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
Line 53: public VmManagementParametersBase(VmStatic vmStatic) {
Line 54: super(vmStatic.getId());
Line 55: _vmStatic = vmStatic;
Line 56: privateStorageDomainId = Guid.Empty;
Line 57: consoleEnabled = false;
consoleEnabled = Boolean.FALSE, you already did it in the default ctor
Line 58: balloonEnabled = true;
Line 59: }
Line 60:
Line 61: public VmManagementParametersBase(VM vm) {
--
To view, visit http://gerrit.ovirt.org/18138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bb06f63b6fae8d4bc0c2b931cbfeb6b71a023a9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
