Ori Liel has posted comments on this change.
Change subject: restapi: move WatchDog enums to model package
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/model/WatchdogAction.java
Line 1: package org.ovirt.engine.api.restapi.model;
The package change is good, but the enum should move the restapi-definition
project. Make if a neighbour of, for example, VmType.java
Line 2:
Line 3: import org.apache.commons.lang.StringUtils;
Line 4:
Line 5: public enum WatchdogAction {
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/model/WatchdogModel.java
Line 1: package org.ovirt.engine.api.restapi.model;
The package change is good, but the enum should move the restapi-definition
project. Make if a neighbour of, for example, VmType.java
Line 2:
Line 3: import org.apache.commons.lang.StringUtils;
Line 4:
Line 5: public enum WatchdogModel {
--
To view, visit http://gerrit.ovirt.org/18068
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I325d04ca2c0a1a513ef035dfb04ebcc7cd1faa7d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
