Hello Yaniv Bronhaim, Yedidyah Bar David,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18258
to review the following change.
Change subject: API: Do not require root password for host operations
......................................................................
API: Do not require root password for host operations
This allows using public key authentication, and set root_password as
deprecated field.
Change-Id: I506b844df10acfc17dcbce271755d37fdcdf0c7e
Signed-off-by: Yedidyah Bar David <[email protected]>
Signed-off-by: Yaniv Bronhaim <[email protected]>
---
M
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
M
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java
3 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/18258/1
diff --git
a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
index 6b3c2ea..1021e55 100644
---
a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
+++
b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
@@ -1855,7 +1855,7 @@
parameterType: Host
signatures:
- mandatoryArguments: {}
- optionalArguments: {host.name: 'xs:string', host.comment: 'xs:string',
host.address: 'xs:string', host.root_password: 'xs:string',
+ optionalArguments: {host.name: 'xs:string', host.comment: 'xs:string',
host.address: 'xs:string', host.root_password--DEPRECATED: 'xs:string',
host.display.address: 'xs:string', host.cluster.id|name:
'xs:string', host.port: 'xs:int', host.storage_manager.priority: 'xs:int',
host.power_management.type: 'xs:string',
host.power_management.enabled: 'xs:boolean', host.power_management.address:
'xs:string',
host.power_management.username: 'xs:string',
host.power_management.password: 'xs:string',
@@ -1881,7 +1881,7 @@
body:
parameterType: Host
signatures:
- - mandatoryArguments: {host.name: 'xs:string', host.address:
'xs:string', host.root_password: 'xs:string', host.cluster.id|name: 'xs:string'}
+ - mandatoryArguments: {host.name: 'xs:string', host.address:
'xs:string', host.root_password--DEPRECATED: 'xs:string', host.cluster.id|name:
'xs:string'}
optionalArguments: {host.comment: 'xs:string', host.port: 'xs:int',
host.display.address: 'xs:string', host.storage_manager.priority:
'xs:int', host.power_management.type: 'xs:string',
host.power_management.enabled: 'xs:boolean',
host.power_management.address: 'xs:string', host.power_management.username:
'xs:string',
@@ -1966,6 +1966,7 @@
signatures:
- mandatoryArguments: {}
optionalArguments: {action.root_password: 'xs:string', action.image:
'xs:string'}
+ deprecated: true
- mandatoryArguments: {}
optionalArguments: {action.ssh.password: 'xs:string', action.image:
'xs:string'}
urlparams: {}
diff --git
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
index a1b81dd..34047dc 100644
---
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
+++
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
@@ -87,7 +87,7 @@
@Override
public Response add(Host host) {
validateEnums(Host.class, host);
- validateParameters(host, "name", "address", "rootPassword");
+ validateParameters(host, "name", "address");
VdsStatic staticHost = getMapper(Host.class,
VdsStatic.class).map(host, null);
staticHost.setVdsGroupId(getClusterId(host));
AddVdsActionParameters addParams = new
AddVdsActionParameters(staticHost, host.getRootPassword());
diff --git
a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java
b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java
index ab5048f..abc00b5 100644
---
a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java
+++
b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java
@@ -262,7 +262,7 @@
collection.add(model);
fail("expected WebApplicationException on incomplete parameters");
} catch (WebApplicationException wae) {
- verifyIncompleteException(wae, "Host", "add", "address",
"rootPassword");
+ verifyIncompleteException(wae, "Host", "add", "address");
}
}
--
To view, visit http://gerrit.ovirt.org/18258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I506b844df10acfc17dcbce271755d37fdcdf0c7e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
