Allon Mureinik has posted comments on this change.
Change subject: engine,webadmin: Limit usage of Local ISO SD to Local DC
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java
Line 47: }
Line 48:
Line 49: if (retVal &&
Line 50: (getStorageDomain().getStorageDomainType() ==
StorageDomainType.Data ||
Line 51: getStorageDomain().getStorageDomainType()
== StorageDomainType.ISO) &&
IMHO, the storage domain type is a mute point.
As we've seen in the bugs this patch addresses, it's /never/ OK to attach a
local domain to a non-local pool.
Currently, we only have local ISO and DATA domain. Tomorrow, if we add support
for a local EXPORT domain, attaching it to an NFS pool will be wrong too.
Line 52: storagePool.getStorageType() !=
StorageType.LOCALFS) {
Line 53:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_IS_NOT_LOCAL);
Line 54: retVal = false;
Line 55: }
--
To view, visit http://gerrit.ovirt.org/18229
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cfc3bb68581664fa6729e5cb8a163324e7fbc29
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
