plysan has posted comments on this change.
Change subject: engine: check active vds before activate storage domain
......................................................................
Patch Set 3:
(3 comments)
See in line comment.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
Line 58:
VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_STATUS_ILLEGAL)
Line 59: && checkStorageDomain()
Line 60: && storageDomainStatusIsValid()
Line 61: && (getStorageDomain().getStorageDomainType() ==
StorageDomainType.Master || checkMasterDomainIsUp())
Line 62: && checkActiveVdsInStoragePool();
Thanks for the tip.
Line 63: return returnValue;
Line 64: }
Line 65:
Line 66: @Override
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 214: return true;
Line 215: }
Line 216: }
Line 217:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NO_ACTIVE_HOST_IN_STORAGE_POOL);
Line 218: return false;
Thanks for the tip, this is the better way.
Line 219: }
Line 220:
Line 221: protected void setStorageDomainStatus(StorageDomainStatus status,
CompensationContext context) {
Line 222: if (getStorageDomain() != null &&
getStorageDomain().getStoragePoolId() != null) {
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 479: VM_CANNOT_REMOVE_WITH_DETACH_DISKS_SNAPSHOTS_EXIST=Cannot ${action}
${type} with detaching disks, snapshots exist.
Line 480: VM_CANNOT_REMOVE_WITH_DETACH_DISKS_BASED_ON_TEMPLATE=Cannot ${action}
${type} with detaching disks, VM is based from template.
Line 481: ACTION_TYPE_FAILED_MASTER_STORAGE_DOMAIN_NOT_ACTIVE=Failed to
${action} ${type} due to an error on the Data Center master Storage Domain.\n\
Line 482: -Please activate the master Storage Domain first.
Line 483: ACTION_TYPE_FAILED_NO_ACTIVE_HOST_IN_STORAGE_POOL=Failed to ${action}
${type}. No active host found. Please make sure there is at least one 'Up' host
in Data Center.
I think there is difference between NO_VDS and NO_ACTIVE_HOST, but changing it
to NO_ACTIVE_VDS is better.
Line 484: TAGS_SPECIFY_TAG_IS_NOT_EXISTS=The specified Tag does not exist.
Line 485: NETWORK_CANNOT_REMOVE_NETWORK_IN_USE_BY_TEMPLATE=Cannot ${action}
${type}. The Network is in use by a Template.\n\
Line 486: Network definition cannot be detached unless all references to
it are cleared.
Line 487: NETWORK_CANNOT_CHANGE_STATUS_WHEN_NOT_DOWN_UP=Cannot ${action}
${type}. Changing interface properties is allowed only when the VM is in 'Up'
or 'Down' status.
--
To view, visit http://gerrit.ovirt.org/17940
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3e45b53d15b757237af8c76457f213c00a73909
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: plysan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: LiJiansheng <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: plysan <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
