Alona Kaplan has posted comments on this change. Change subject: webadmin: Fix QoS empty selection bug ......................................................................
Patch Set 1: (1 comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java Line 89: profileView, null, false); Line 90: Line 91: NetworkQoS networkQoS = new NetworkQoS(); Line 92: networkQoS.setName(profileView.getNetworkQosName() == null Line 93: ? ConstantsManager.getInstance().getConstants().unlimitedQoSTitle() This code duplicated the code in VnicProfileModel. Consider extracting it to a public method in VnicProfileModel. Line 94: : profileView.getNetworkQosName()); Line 95: editModel.getNetworkQoS().setSelectedItem(networkQoS); Line 96: Line 97: editModel.getNetworkQoS().setIsChangable(false); -- To view, visit http://gerrit.ovirt.org/18072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I056f3291298426ed71fd75052fc5bc977b1591e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
