Allon Mureinik has posted comments on this change.
Change subject: frontend: identify user roles using enum values
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java
Line 43: // suppose to be action group
Line 44: thirdNode.setIsChangable(!isReadOnly);
Line 45: thirdNode.setIsSelectedNullable(false);
Line 46: thirdNode.setTooltip(third.getTooltip());
Line 47: if (isAdmin ||
ActionGroup.valueOf(thirdNode.getTitle()).getRoleType() == RoleType.USER) {
shouldn't this be !isAdmin ?
Line 48: secondNode.getChildren().add(thirdNode);
Line 49: }
Line 50: }
Line 51: if (secondNode.getChildren().size() > 0)
--
To view, visit http://gerrit.ovirt.org/18145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2de0478fc80952c9a5816bd58a1d000df77a6681
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
