Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: make column width persistent
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
Line 221:
Line 222: // column resizing persistence -- can be enabled only when
the tableHeader widget is visible
Line 223: if (!showDefaultHeader) {
Line 224: tableHeader.enableColumnWidthPersistence(clientStorage,
dataProvider.getModel());
Line 225: table.enableColumnWidthPersistence(clientStorage,
dataProvider.getModel());
You are right, we need to call enableColumnWidthPersistence on "table" widget
too, due to logic in ColumnResizeCellTable.setColumnWidth that reads and
applies persisted column width. I missed the fact that this logic needs to
execute for "table" widget too, to ensure "table" and "tableHeader" widget use
same column widths.
In case of AbstractActionTable, tableHeader.onResizeEnd should always be called
(user interacts with "tableHeader" widget) and table.onResizeEnd should never
be called (due to "table" widget having its header part non-visible), so we
should be safe to assume ColumnResizeCellTable.onResizeEnd (logic to persist
column width) will be called just once.
Line 226: }
Line 227:
Line 228: }
Line 229:
--
To view, visit http://gerrit.ovirt.org/17118
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I761e12de743fc9b5fce9edf52b929200abe25c8c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
