Doron Fediuck has posted comments on this change.

Change subject: engine: junit test for external scheduler broker
......................................................................


Patch Set 3:

(1 comment)

....................................................
File backend/manager/modules/bll/pom.xml
Line 144: 
Line 145:     <dependency>
Line 146:       <groupId>org.apache.xmlrpc</groupId>
Line 147:       <artifactId>xmlrpc-server</artifactId>
Line 148:       <version>3.1.3</version>
Laszlo,
It is better to use something like ${xml-rpc-server.version} and define it in 
the root pom.xml. In this way we can make sure we're using the same version all 
over.
See ${slf4j-jdk14.version} above as an example.
Line 149:       <scope>test</scope>
Line 150:     </dependency>
Line 151:   </dependencies>
Line 152: 


-- 
To view, visit http://gerrit.ovirt.org/18306
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd51a58b25e6f44a0dc979af1d54aeee7dd5dd7c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to