Kanagaraj M has posted comments on this change.
Change subject: webadmin : changed create volume to new and sub tab title to
general
......................................................................
Patch Set 5:
(3 comments)
Please rebase.
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
Line 231: @DefaultStringValue("Volumes")
Line 232: String volumesTitle();
Line 233:
Line 234: @DefaultStringValue("New Volume")
Line 235: String createVolumeTitle();
please refactor this method name as well
Line 236:
Line 237: @DefaultStringValue("Parameters")
Line 238: String parameterTitle();
Line 239:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 91: @DefaultStringValue("Providers")
Line 92: String providerMainTabLabel();
Line 93:
Line 94: @DefaultStringValue("General")
Line 95: String volumeGeneralSubTabLabel();
As Sahina pointed out, remove this change from the patch
Line 96:
Line 97: @DefaultStringValue("Volume Options")
Line 98: String volumeParameterSubTabLabel();
Line 99:
Line 2450: @DefaultStringValue("Status")
Line 2451: String statusVolume();
Line 2452:
Line 2453: @DefaultStringValue("New")
Line 2454: String createVolumeVolume();
Refactor the method name
Line 2455:
Line 2456: @DefaultStringValue("Remove")
Line 2457: String removeVolume();
Line 2458:
--
To view, visit http://gerrit.ovirt.org/17663
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib32adbb4c0c59c5e30bc1d22c3c42d40c47cca0b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
