Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: remove unnecessary DocsURL config
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
One minor comment but otherwise +1 for frontend part.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
Line 331: protected abstract String clientPlatformType();
Line 332:
Line 333: public abstract Float clientBrowserVersion();
Line 334:
Line 335: protected abstract void fetchDocumentationFile();
I think this abstract method declaration can be removed, since
fetchDocumentationFile() is used only in Configurator subclasses,
Line 336:
Line 337: public boolean isSpiceProxyDefined() {
Line 338: String spiceProxy = (String)
AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.SpiceProxyDefault);
Line 339: return spiceProxy != null && !"".equals(spiceProxy);
//$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/18152
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e6dec7c400778a27b225a9416cb504235576901
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
