Gilad Chaplik has posted comments on this change.
Change subject: engine: test for ExternalSchedulerDiscoveryThread
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java
Line 59:
Line 60: reloadPolicyUnits();
Line 61: }
Line 62:
Line 63: void reloadPolicyUnits() {
no access modifier?
Line 64: SchedulingManager.getInstance().reloadPolicyUnits();
Line 65: }
Line 66:
Line 67: private void markExternalPoliciesAsDisabled(List<PolicyUnit>
units) {
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThreadTest.java
Line 22: import org.ovirt.engine.core.compat.Guid;
Line 23: import org.ovirt.engine.core.dao.scheduling.PolicyUnitDao;
Line 24: import org.ovirt.engine.core.utils.MockConfigRule;
Line 25:
Line 26: public class ExternalSchedulerDiscoveryThreadTest {
are you sure we want to start a real live server in the tests?
can't we mock the results from the server?
Line 27: final static private int testPort = 12345;
Line 28: private static WebServer server;
Line 29:
Line 30: @Rule
--
To view, visit http://gerrit.ovirt.org/18333
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I616f4063847686c6bab2366b57030f68ac80b73c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
