Moti Asayag has posted comments on this change.

Change subject: engine: Ties more consistently between vm nic device and vm nic 
entities.
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

a very tiny comment...

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 932:     public Map<Guid, Guid> getSrcDeviceIdToTargetDeviceIdMapping() {
Line 933:         Map<Guid, Guid> srcDeviceIdToTargetDeviceIdMapping = new 
HashMap<>();
Line 934:         
srcDeviceIdToTargetDeviceIdMapping.putAll(srcVmNicIdToTargetVmNicIdMapping);
Line 935:         
srcDeviceIdToTargetDeviceIdMapping.putAll(srcDiskIdToTargetDiskIdMapping);
Line 936:         return  srcDeviceIdToTargetDeviceIdMapping;
there is an extra space after the return.
Line 937:     }


-- 
To view, visit http://gerrit.ovirt.org/18362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9267ade386ab83a6c353b4206f4dfe003f24bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to