Yair Zaslavsky has posted comments on this change.
Change subject: engine:Start Rebalance Gluster volume command
......................................................................
Patch Set 15:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
Line 51: || (glusterVolume.getVolumeType() ==
GlusterVolumeType.STRIPE && glusterVolume.getBricks().size() <=
glusterVolume.getStripeCount())
Line 52: || (glusterVolume.getBricks().size() == 1)) {
Line 53:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_BRICKS_ARE_NOT_DISTRIBUTED);
Line 54: return false;
Line 55: }
Then use the InMemoryLocking mechanism (getExclusiveLock on the gluster volume
) + @LockIdNameAttribute
)
You should also ask yourself if you can for example erase/destory (whatever
your terminology is) a Gluster volume while rebalancing (i.e - the same one) -
once again, if the answer is no, InMemoryLocking mechanism can help you out.
Line 56: return true;
Line 57: }
Line 58:
Line 59: @Override
--
To view, visit http://gerrit.ovirt.org/12389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaae7cf53bd77e9b717b268bcf0de91ba515af40c
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
