Lior Vernia has uploaded a new change for review. Change subject: webadmin: Revert findbugs fix that caused regression ......................................................................
webadmin: Revert findbugs fix that caused regression A findbugs fix removed a "redundant" null check, which caused the Setup Host Networks dialog to malfunction. There was indeed a redundant null check, but not the one that was removed. Bug-Url: https://bugzilla.redhat.com/975886 Change-Id: I8b19c8588168281734e76e08ce98105ae5721941 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/18386/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java index 956071e..ee6b857 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java @@ -181,7 +181,7 @@ NetworkItemModel<?> op1 = nic1 == null ? network1 : nic1; NetworkItemModel<?> op2 = nic2 == null ? network2 : nic2; - if (op1 == null || op2 == null) { + if (op1 == null) { throw new IllegalArgumentException("null Operands"); //$NON-NLS-1$ } -- To view, visit http://gerrit.ovirt.org/18386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8b19c8588168281734e76e08ce98105ae5721941 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
