Hello Ravi Nori,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18402
to review the following change.
Change subject: tools : engine-config should return the list of possible VNC
keyboard layouts
......................................................................
tools : engine-config should return the list of possible VNC keyboard layouts
Changing the default VNC keyboard layout is possible via engine-config.
There should be an indication to what are the possible values.
The information on the possible layouts is stored at vdc_options table
(VncKeyboardLayoutValidValues option name)
Change-Id: I33c37b22501c64cad694e28941bd5df181bbbe6f
Bug-Url: https://bugzilla.redhat.com/987952
Signed-off-by: Ravi Nori <[email protected]>
---
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/18402/1
diff --git
a/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java
b/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java
index 2564f80..9c19be2 100644
---
a/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java
+++
b/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java
@@ -22,12 +22,16 @@
List<String> validValues = key.getValidValues();
boolean isValid = false;
+ String details = "";
if (validValues.isEmpty()) {
isValid = true;
} else {
isValid = validValues.contains(value);
+ if (!isValid) {
+ details = "Valid values are "+key.getValidValues();
+ }
}
- return new ValidationResult(isValid);
+ return new ValidationResult(isValid, details);
}
@Override
--
To view, visit http://gerrit.ovirt.org/18402
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33c37b22501c64cad694e28941bd5df181bbbe6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
