Arik Hadas has posted comments on this change.
Change subject: core: Use container id for memory lock in import process.
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Nice solution, just consider to add a comment in the code that explains it
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 133: }
Line 134:
Line 135: @Override
Line 136: protected Map<String, Pair<String, String>> getSharedLocks() {
Line 137: return Collections.singletonMap(super.getVmId().toString(),
how about adding a comment that explains it? in two days we'll forget why we
call 'super' here :)
Line 138: LockMessagesMatchUtil.makeLockingPair(
Line 139: LockingGroup.REMOTE_VM,
Line 140: getVmIsBeingImportedMessage()));
Line 141: }
--
To view, visit http://gerrit.ovirt.org/18416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie849300bdc98020aeca90deeddafd12295e8211a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
