Lior Vernia has posted comments on this change.
Change subject: webadmin: Changed units of Network QoS in UI
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Please see comments and address them as you wish.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 3057:
Line 3058: @DefaultStringValue("Mbps")
Line 3059: String mbpsLabelQoSPopup();
Line 3060:
Line 3061: @DefaultStringValue("MiB")
According to the commit message this fix is intentional. Ofri, I'm sure that
libvirt does accept KiB in which case you should hold the value in MiB, however
their documentation says Kilobytes and not Kebibytes. Consider following their
documentation and using MB even though I suspect it's an error on their
behalf...
Line 3062: String mbLabelQoSPopup();
Line 3063:
Line 3064: @DefaultStringValue("Cluster Policies")
Line 3065: String configureClusterPolicyTabLabel();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java
Line 140: inboundPeakEditor.setTitle(constants.peakNetworkQoSPopup() +
constants.inMegabitsNetworkQoSPopup());
Line 141: inboundBurstEditor.setTitle(constants.burstNetworkQoSPopup()
+ constants.inMegabytesNetworkQoSPopup());
Line 142:
outboundAverageEditor.setTitle(constants.averageNetworkQoSPopup() +
constants.inMegabitsNetworkQoSPopup());
Line 143: outboundPeakEditor.setTitle(constants.peakNetworkQoSPopup() +
constants.inMegabitsNetworkQoSPopup());
Line 144: outboundBurstEditor.setTitle(constants.burstNetworkQoSPopup()
+ constants.inMegabytesNetworkQoSPopup());
Consider adding a spacebar between the parameter name and the units, you know
best if it looks okay without it or not.
Line 145: }
Line 146:
Line 147: @Override
Line 148: public void edit(NetworkQoSModel object) {
--
To view, visit http://gerrit.ovirt.org/18395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd2367b136d547f7f93fdc8a1b76561920ce59a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
