Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: handle bond and bridge interfaces
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
....................................................
File src/plugins/ovirt-hosted-engine-setup/network/bridge.py
Line 103
Line 104
Line 105
Line 106
Line 107
Nice!
You might want to add here something like:
if (enslaved):
raise RuntimeError('The following existing interfaces are not suitable for
vdsm: {enslaved}. You might want to pull out an interface out of a bridge to be
able to use it')
...
--
To view, visit http://gerrit.ovirt.org/18406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If19dfa2c2b9b02ba8d997ad1758614fad3470eb5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Leonid Natapov <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
