Sahina Bose has posted comments on this change.
Change subject: gluster: VDS Cmd: Gluster volume rebalance status
......................................................................
Patch Set 10:
(2 comments)
Are we having a generic command for taskStatus, instead of RebalanceStatus ,
RemoveBrickStatus?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeTaskStatusVDSCommand.java
Line 5: import
org.ovirt.engine.core.common.businessentities.gluster.GlusterVolumeTaskStatusEntity;
Line 6: import
org.ovirt.engine.core.common.vdscommands.gluster.GlusterVolumeVDSParameters;
Line 7: import org.ovirt.engine.core.vdsbroker.vdsbroker.StatusForXmlRpc;
Line 8:
Line 9: public class GetGlusterVolumeTaskStatusVDSCommand <P extends
GlusterVolumeVDSParameters> extends AbstractGlusterBrokerCommand<P> {
Is the command the same for all tasks? that's rebalance, replace-brick?
In that case, wouldn't replace-brick require additional parameters?
Line 10: private GlusterVolumeTaskReturnForXmlRpc result;
Line 11:
Line 12: public GetGlusterVolumeTaskStatusVDSCommand(P parameters) {
Line 13: super(parameters);
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeTaskReturnForXmlRpc.java
Line 47:
Line 48: return rebalanceStatusForNode;
Line 49: }
Line 50:
Line 51: private GlusterVolumeTaskStatus getAggregateStatus(Map<String,
Object> aggregateStatus) {
getAggregateStatus and getStatusForNode are very similar. Consider reusing
Line 52: GlusterVolumeTaskStatus status = new GlusterVolumeTaskStatus();
Line 53:
status.setFilesScanned(Integer.parseInt((String)aggregateStatus.get(FILES_SCANNED)));
Line 54:
status.setFilesMoved(Integer.parseInt((String)aggregateStatus.get(FILES_MOVED)));
Line 55:
status.setFilesSkipped(Integer.parseInt((String)aggregateStatus.get(FILES_SKIPPED)));
--
To view, visit http://gerrit.ovirt.org/18308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a5ec48feffac42ec073f2d6f9c91ecd5ef57da
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
