Yaniv Bronhaim has posted comments on this change. Change subject: core: Adding Version utils ......................................................................
Patch Set 3: Yair, I prefer seeing copies of whatever you need from Version class instead of having two version utils. Now you hold Version, RpmVersion, VersionUtils, each in different package. First start with calling your new util - RpmVersionUtil because it does only manipulations for Rpm Versions (not for cluster version for example). Second, keeping old version class is ok, just aim to stop using it, by separate rpmVersion implementation from Version (its quite simple. why delaying it?), then you'll be able to merge rpmVersion to the new rpmVersionUtil. -- To view, visit http://gerrit.ovirt.org/18370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia82d09e755b767f254224c84abd16516592715ac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
