Yair Zaslavsky has posted comments on this change.
Change subject: engine: Initialize array 'imageParameters' in
VdcActionParametersBase
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
Line 81: private void removeVmImages() {
Line 82: // Remove vm images, in case they were not already removed by
child commands
Line 83: List<VdcActionParametersBase> imageParams =
getParameters().getImagesParameters();
Line 84: for (VdcActionParametersBase param : imageParams) {
Line 85: DiskImage diskImage =
getDiskImageToRemoveByParam((MoveOrCopyImageGroupParameters) param);
hmm, formatting issues, or am i missing real thing here?
Line 86: if (diskImage != null) {
Line 87: ImagesHandler.removeDiskImage(diskImage, getVmId());
Line 88: }
Line 89: }
--
To view, visit http://gerrit.ovirt.org/18475
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fdaf131ed3d1bbfadcdd60df3feb6b828c05d0c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
