Arik Hadas has posted comments on this change.
Change subject: core: minor cleanup in MigrateVmToServerCommand
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java
Line 29: if
(!vm.getVdsGroupId().equals(getDestinationVds().getVdsGroupId())) {
Line 30: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_MIGRATE_BETWEEN_TWO_CLUSTERS);
Line 31: }
Line 32:
Line 33: return super.canDoAction();
it can be together, but it will be better to separate the cleanup/refactoring
from bug fixing I think - let's say that we'll want to backport the bug fix for
previous version, by separating to different patch it would be easier to
backport
Line 34: }
Line 35:
Line 36: /**
Line 37: * In case we failed to migrate to that specific server, the VM
should no longer be pending,
--
To view, visit http://gerrit.ovirt.org/18469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic455ae7ba1a38cd8d7e67e4d925d2ce18493227a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
