Juan Hernandez has uploaded a new change for review.
Change subject: core: Make coverity happy
......................................................................
core: Make coverity happy
Some recent changes have introduced a construct that forces the java
compiler to infer the type of a generic method from its use inside the
condition of an if, for example:
if(Config.GetValue(ConfigValues.ExternalSchedulerEnabled)) {
...
}
The usual (which doesn't mean nice) syntax for this is the following:
if(Config.<Boolean> GetValue(ConfigValues.ExternalSchedulerEnabled)) {
...
}
While the recently introduced syntax is nicer, unfortunatelly it makes
coverity choke.
This patch reverts to the old style, just to make coverity happy.
Change-Id: I2eb133de6fab92eaaf0edd8a99af2fc406f6b088
Signed-off-by: Juan Hernandez <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/18496/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
index fc6695c..0ef33c5 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
@@ -82,7 +82,7 @@
log.info("Initializing Scheduling manager");
loadPolicyUnits();
loadClusterPolicies();
- if(Config.GetValue(ConfigValues.ExternalSchedulerEnabled)) {
+ if(Config.<Boolean> GetValue(ConfigValues.ExternalSchedulerEnabled)) {
log.info("Starting external scheduler dicovery thread");
ExternalSchedulerDiscoveryThread discoveryThread = new
ExternalSchedulerDiscoveryThread();
discoveryThread.start();
@@ -600,7 +600,7 @@
List<VDS> hosts =
getVdsDAO().getAllForVdsGroupWithoutMigrating(cluster.getId());
if (policyUnit.isInternal()) {
balanceResult = internalRunBalance(policyUnit, cluster,
hosts);
- } else if
(Config.GetValue(ConfigValues.ExternalSchedulerEnabled)) {
+ } else if (Config.<Boolean>
GetValue(ConfigValues.ExternalSchedulerEnabled)) {
balanceResult = externalRunBalance(policyUnit, cluster,
hosts);
}
}
--
To view, visit http://gerrit.ovirt.org/18496
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2eb133de6fab92eaaf0edd8a99af2fc406f6b088
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
