Alissa Bonas has posted comments on this change.

Change subject: core: not allow detach last storage connection
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageConnectionValidator.java
Line 76:     }
Line 77: 
Line 78:     public boolean isLastConnectionForDomain(StorageDomain 
storageDomain) {
Line 79:         List<StorageServerConnections> connectionsForDomain = 
getAllConnectionsForDomain(storageDomain.getId());
Line 80:         if (connectionsForDomain.size() == 1 && 
isConnectionAttachedToDomain(connectionsForDomain)) {
because it has several usecases where it needs to go over all the connections.
Line 81:             return true;
Line 82:         }
Line 83:         return false;
Line 84:     }


-- 
To view, visit http://gerrit.ovirt.org/18314
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf67c945381e8d0d47e5f6b2878f3bd2a571b5b6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to