Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: copy virtio files if they exist ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/image_upload.py Line 70: stage=plugin.Stages.STAGE_SETUP, Line 71: ) Line 72: def _setup(self): Line 73: if not self.environment[osetupcons.CoreEnv.DEVELOPER_MODE]: Line 74: for filename in self._fileList: I think this should be moved to validation, along with the NFS_CONFIG_ENABLED test Line 75: if os.path.exists(filename): Line 76: self._enabled = True Line 77: Line 78: @plugin.event( -- To view, visit http://gerrit.ovirt.org/18504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie35c5a3ad38b2f7bdae88c1f8d0790d1a8c988c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
