Tomas Jelinek has posted comments on this change.
Change subject: frontend: [WIP] Control virtio rng device
......................................................................
Patch Set 1:
(6 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 1153:
rngBytesEditor.asValueBox().setValue(dev.getRate().getBytes());
Line 1154: rngRandomRandom.setValue(model ==
VmRngDevice.Backend.Model.DEV_RANDOM);
Line 1155: rngRandomHwrng.setValue(model ==
VmRngDevice.Backend.Model.DEV_HWNNG);
Line 1156: rngEgd.setValue(model ==
VmRngDevice.Backend.Model.EGD);
Line 1157:
rngSourceEgdEditor.asValueBox().setValue(dev.getBackend().getEgdPath());
//$NON-NLS-1$
not needed to use the //$NON-NLS-1$
Line 1158: } });
Line 1159:
Line 1160: // only for non local storage available
Line 1161: setupHostTabAvailability(object);
Line 1491: allowConsoleReconnectEditor.setTabIndex(nextTabIndex++);
Line 1492: isSoundcardEnabledEditor.setTabIndex(nextTabIndex++);
Line 1493: isConsoleDeviceEnabledEditor.setTabIndex(nextTabIndex++);
Line 1494:
Line 1495: // ==Rng Tab==
I would say this should be under the "Boot Options Tab" as it is defined under
this tab in ui.xml so the tab will jump correctly in the left menu.
Line 1496: isRngEnabledEditor.setTabIndex(nextTabIndex++);
Line 1497: rngPeriodEditor.setTabIndex(nextTabIndex++);
Line 1498: rngBytesEditor.setTabIndex(nextTabIndex++);
Line 1499: rngRandomRandom.setTabIndex(nextTabIndex++);
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
Line 544: <e:EntityModelTextBoxEditor
ui:field="rngPeriodEditor"/>
Line 545: <e:EntityModelTextBoxEditor
ui:field="rngBytesEditor" />
Line 546:
Line 547: <g:Label ui:field="rngBackendLabel"
text="{constants.deviceBackend}" addStyleNames="{style.sectionLabel}" />
Line 548: <g:HorizontalPanel
verticalAlignment='ALIGN_MIDDLE'>
please change to FlowPanel - we are trying to avoid tables if possible.
Line 549: <g:RadioButton
ui:field="rngRandomRandom" addStyleNames="{style.radioButton}"/>
Line 550: <g:Label
text="{constants.rngSourceRandom}" />
Line 551: </g:HorizontalPanel>
Line 552: <g:HorizontalPanel
verticalAlignment='ALIGN_MIDDLE'>
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
Line 194: : vmWatchdog.getModel().name());
Line 195: }
Line 196: }
Line 197: }));
Line 198: Frontend.RunQuery(VdcQueryType.GetRngDevice, new
IdQueryParameters(getVm().getId()), new AsyncQuery(this,
please move this copy - pasted code to some upper class
Line 199: new INewAsyncCallback() {
Line 200: @Override
Line 201: public void onSuccess(Object model, Object
returnValue) {
Line 202: @SuppressWarnings("unchecked")
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
Line 174: }
Line 175: }
Line 176:
Line 177: private void setRngDevice(Guid templateId) {
Line 178: Frontend.RunQuery(VdcQueryType.GetRngDevice, new
IdQueryParameters(templateId), new AsyncQuery(this,
please move this copy - pasted code to some upper class
Line 179: new INewAsyncCallback() {
Line 180: @Override
Line 181: public void onSuccess(Object model, Object
returnValue) {
Line 182: @SuppressWarnings("unchecked")
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
Line 101: }
Line 102: }
Line 103: }), template.getId());
Line 104:
Line 105: Frontend.RunQuery(VdcQueryType.GetRngDevice, new
IdQueryParameters(template.getId()), new AsyncQuery(this,
please move this copy - pasted code to some upper class
Line 106: new INewAsyncCallback() {
Line 107: @Override
Line 108: public void onSuccess(Object model, Object
returnValue) {
Line 109: @SuppressWarnings("unchecked")
--
To view, visit http://gerrit.ovirt.org/18497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffbc48062f25d90795bc360362f42cd1042fb888
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
