Alissa Bonas has uploaded a new change for review. Change subject: core: remove unused variables ......................................................................
core: remove unused variables Find bugs cleanup. Removed unused variables. Change-Id: I16e2f536c7f7d61f0b357deb9abaac63893403cc Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 3 files changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/18543/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java index dc7bc24..d97ddbe 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java @@ -444,7 +444,6 @@ } protected void AddVmTemplateImages(Map<Guid, Guid> srcDeviceIdToTargetDeviceIdMapping) { - Guid vmSnapshotId = Guid.newGuid(); for (DiskImage diskImage : mImages) { // The return value of this action is the 'copyImage' task GUID: VdcReturnValueBase retValue = executeChildCommand(diskImage.getImageId()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java index c7645cb..f5a9be0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java @@ -68,7 +68,6 @@ @Override protected boolean canDoAction() { - boolean returnValue = true; StorageServerConnections paramConnection = getConnection(); // if an id was sent - it's not ok since only the backend should allocate ids if (StringUtils.isNotEmpty(paramConnection.getid())) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java index f8480f5..ca5df40 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java @@ -235,7 +235,6 @@ boolean soundDeviceEnabled, boolean isConsoleEnabled) { Guid id; - int ifaceCount = 0; String isoPath=vmBase.getIsoPath(); // indicates that VM should have CD either from its own (iso_path) or from the snapshot it was cloned from. boolean shouldHaveCD = StringUtils.isNotEmpty(isoPath); -- To view, visit http://gerrit.ovirt.org/18543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I16e2f536c7f7d61f0b357deb9abaac63893403cc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
