Hello Laszlo Hornyak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18573
to review the following change.
Change subject: engine: EditClusterPolicyCommand simplification
......................................................................
engine: EditClusterPolicyCommand simplification
EditClusterPolicyCommand canDoAction simplification
Change-Id: If04225e711bffefe87f3f2496bb0a17e8c48f95d
Signed-off-by: Laszlo Hornyak <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/EditClusterPolicyCommand.java
1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/18573/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/EditClusterPolicyCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/EditClusterPolicyCommand.java
index 9b70c79..65462ad 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/EditClusterPolicyCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/EditClusterPolicyCommand.java
@@ -13,13 +13,7 @@
@Override
protected boolean canDoAction() {
- if (!checkRemoveEditValidations()) {
- return false;
- }
- if (!checkAddEditValidations()) {
- return false;
- }
- return true;
+ return checkRemoveEditValidations() && checkAddEditValidations();
}
@Override
--
To view, visit http://gerrit.ovirt.org/18573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If04225e711bffefe87f3f2496bb0a17e8c48f95d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
