Ravi Nori has posted comments on this change.

Change subject: cli: bogous 'help show event' output
......................................................................


Patch Set 1:

(1 comment)

....................................................
File src/ovirtcli/utils/methodhelper.py
Line 173:                             typ = ' '.join(splitted_line[2:3])
Line 174:                             if prefix.startswith('['):
Line 175:                                 typ = typ + ']'
Line 176:                         else:
Line 177:                             typ = ' '.join(splitted_line[2:])
Hi Michael,

There is no 'theidoftheentity' or 'the id of the entity' in rsdl

If I understand correctly ovirt-engine-sdk/src/codegen/utils/paramscontainer.py 
has the keyword 'the id of the entity' with proper spacing which gets used to 
generate 

ovirt-engine-sdk/src/ovirtsdk/infrastructure/brokers.py

In the orginal code snippet, we are splitting the line into words and appending 
it with out spaces resulting in theidoftheentity. 

This patch fixes it
Line 178: 
Line 179:                         if param.find('.') != -1:
Line 180:                             splitted_param = param.split('.')
Line 181:                             new_param = 
PERIOD_SYMBOL.join(splitted_param[1:])


-- 
To view, visit http://gerrit.ovirt.org/16780
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8dfe2a5d4fd7830a184f87deb51aabd2fcd0d41
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to