Mike Kolesnik has posted comments on this change.
Change subject: engine: Consider case-sensitivity for mac-address uniqueness
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
Line 31: /**
Line 32: * A Map that holds the allocated MAC addresses as keys, and
counters as values. These MAC addresses were taken from
Line 33: * the range defined by the user in {@link
ConfigValues#MacPoolRanges}
Line 34: */
Line 35: private final CaseInsensitiveMap allocatedMacs = new
CaseInsensitiveMap();
Why change the type of the reference?
I don't think it adds much value that can't be found by looking at the field's
javadoc (which should probably be updated).
Even in the javadoc for CaseInsensitiveMap you see they don't hold the
reference type as CaseInsensitiveMap but rather as just Map
Line 36:
Line 37: /**
Line 38: * A Map that holds the allocated MAC addresses as keys, and
counters as values. These MAC addresses were allocated
Line 39: * when user requested a specific MAC address that is out of the
range defined in {@link ConfigValues#MacPoolRanges}
Line 37: /**
Line 38: * A Map that holds the allocated MAC addresses as keys, and
counters as values. These MAC addresses were allocated
Line 39: * when user requested a specific MAC address that is out of the
range defined in {@link ConfigValues#MacPoolRanges}
Line 40: */
Line 41: private final CaseInsensitiveMap allocatedCustomMacs = new
CaseInsensitiveMap();
Same question..
Line 42:
Line 43: /**
Line 44: * A Set that holds the non-allocated MAC addresses from the range
defined in {@link ConfigValues#MacPoolRanges}
Line 45: * Every MAC in that range should either be in this Set, or be
mapped to a value greater to zero in allocatedMacs,
--
To view, visit http://gerrit.ovirt.org/18490
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57516cc710648b37a9cebcdfce592c2418a7e192
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
