Martin Sivák has posted comments on this change.
Change subject: External scheduler: real rest api example
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
....................................................
File plugins/example.py
Line 21:
Line 22: #get our parameters from the map
Line 23: try:
Line 24: minimum_cores = int(args_map.get('minimum_cores'))
Line 25: except:
Please use:
int(args_map.get('minimum_cores', '4'))
instead of the try: except: block.
Line 26: minimum_cores = 4
Line 27:
Line 28: #get all the hosts with the given ids
Line 29: engine_hosts = \
--
To view, visit http://gerrit.ovirt.org/18415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I395774e95ae4481be03076c7250b776d5abb0d36
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
