Michael Pasternak has posted comments on this change. Change subject: cli: Enable update of VM with integer name ......................................................................
Patch Set 1: Code-Review-2 (3 comments) .................................................... Commit Message Line 10: user quotes the name of vm it will be interpreted as name not an id. Line 11: Line 12: For example: update vm '12345' --description testdescription Line 13: Will update a VM with the name 12345 instead of returning error Line 14: that VM with id 12345 does not exist. this is wrong, we have entities (such as events) in the system with id of type long, since the name of the entity is ambiguous in terms of id/name , one should use the id (UUID) of the vm for identification and not the name Line 15: Line 16: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=977566 Line 17: Change-Id: I5c54b646f057d2f39b85ab0ca6c448308c06ecce .................................................... File AUTHORS Line 1: The following people have contributed to this project. Line 2: Line 3: * Michael Pasternak <[email protected]> Line 4: * Geert Jansen <[email protected]> Line 5: * Martin Betak <[email protected]> martin, i don't mind you being one of the authors of the cli, but prefer you contributing a feature rather than fixing something ... .................................................... File src/ovirtcli/command/command.py Line 360 Line 361 Line 362 Line 363 Line 364 this change is wrong, we have entities (such as events) in the system with id of type long, and all params comes from command line as strings, so removing digit extraction from the string will create a regression where long/digit based IDs will not be supported. -- To view, visit http://gerrit.ovirt.org/18595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c54b646f057d2f39b85ab0ca6c448308c06ecce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
