Yaniv Bronhaim has posted comments on this change.
Change subject: frontend: node upgrade detection improvement
......................................................................
Patch Set 19: Code-Review+1
(1 comment)
minor comment
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 1128: ArrayList<RpmVersion> isos =
(ArrayList<RpmVersion>) returnValue;
Line 1129: if (isos.size() > 0)
Line 1130: {
Line 1131: VDS vds =
hostGeneralModel.getEntity();
Line 1132: String [] hostOsInfo =
vds.getHostOs().split("-"); //$NON-NLS-1$ //$NON-NLS-2$
I would move all this part inside to shouldAlertUpgrade
it doesn't related to this part of code
Line 1133: for (int counter = 0; counter <
hostOsInfo.length; counter++) {
Line 1134: hostOsInfo[counter] =
hostOsInfo[counter].trim();
Line 1135: }
Line 1136: hostGeneralModel.setHasUpgradeAlert(
--
To view, visit http://gerrit.ovirt.org/17987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
