Sahina Bose has posted comments on this change.
Change subject: engine:Start Rebalance Gluster volume command
......................................................................
Patch Set 25:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java
Line 20: import org.ovirt.engine.core.dal.job.ExecutionMessageDirector;
Line 21:
Line 22: public abstract class GlusterAsyncCommandBase<T extends
GlusterVolumeParameters> extends GlusterVolumeCommandBase<T> {
Line 23:
Line 24: protected Step asyncTaskStep;
Wouldn't private do?
Line 25:
Line 26: public GlusterAsyncCommandBase(T params) {
Line 27: super(params);
Line 28: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
Line 68:
.RunVdsCommand(VDSCommandType.StartRebalanceGlusterVolume,
Line 69: new
GlusterVolumeRebalanceVDSParameters(upServer.getId(),
Line 70: getGlusterVolumeName(),
Line 71:
getParameters().isFixLayoutOnly(),
Line 72:
getParameters().isForceAction()));
use runVdsCommand method here
Line 73: setSucceeded(taskReturn.getSucceeded());
Line 74: if (!getSucceeded()) {
Line 75:
handleVdsError(AuditLogType.GLUSTER_VOLUME_REBALANCE_START_FAILED,
taskReturn.getVdsError().getMessage());
Line 76: return;
--
To view, visit http://gerrit.ovirt.org/12389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaae7cf53bd77e9b717b268bcf0de91ba515af40c
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
