Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: saving memcheck parameter to answer file
......................................................................
Patch Set 3:
(2 comments)
....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 768:
Line 769: @osetupattrs(
Line 770: answerfile=True,
Line 771: )
Line 772: def LOW_MEMORY_INSTALL(self):
LOW_MEMORY_CHECK?
Line 773: return 'OVESETUP_SYSTEM/lowMemoryInstall'
Line 774: MEMCHECK_MINIMUM_MB = 'OVESETUP_SYSTEM/memCheckMinimumMB'
Line 775: MEMCHECK_RECOMMENDED_MB = 'OVESETUP_SYSTEM/memCheckRecommendedMB'
Line 776:
....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py
Line 132: satisfied and
Line 133: self.environment[
Line 134: osetupcons.SystemEnv.LOW_MEMORY_INSTALL
Line 135: ]
Line 136: ):
this condition is too complex for me...
if (
self.environment[osetupcons.SystemEnv.LOW_MEMORY_INSTALL] and
not satisifed
):
?
Line 137: self.environment[
Line 138: osetupcons.SystemEnv.LOW_MEMORY_INSTALL
Line 139: ] = dialog.queryBoolean(
Line 140: dialog=self.dialog,
--
To view, visit http://gerrit.ovirt.org/18669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I351b129c396d34fb1def8a8ddd1180e21aeeab14
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
