Allon Mureinik has posted comments on this change.
Change subject: core: remove addCanDoActionMessage calls to set variable
replacements
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 380: // (backup) domain
Line 381: if (getParameters().getCopyCollapse() &&
!isTemplateExistsOnExportDomain()) {
Line 382: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_IMPORTED_TEMPLATE_IS_MISSING,
Line 383: String.format("$DomainName %1$s",
Line 384:
getStorageDomainStaticDAO().get(getParameters().getSourceDomainId()).getStorageName()));
if this formatting OK?
looks a bit "funky".
Line 385: }
Line 386:
Line 387: if (!validateVdsCluster()) {
Line 388: return false;
--
To view, visit http://gerrit.ovirt.org/18456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd48fff9200efab6a2a30c7f03f4aa6b4404ad2f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
