Martin Sivák has posted comments on this change.

Change subject: External scheduler: last sample changes
......................................................................


Patch Set 3: Code-Review-1

Can you please inherit all top level classes from object? Old style classes are 
deprecated and miss many useful properties.

Also please use proper naming scheme, class names should be in CamelCase (the 
dummy login has it wrong).

-- 
To view, visit http://gerrit.ovirt.org/18397
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85178aa5d6c67c76c20df3caed3ddc5cf9bc49cc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to