Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Query for gluster volume rebalance status
......................................................................
Patch Set 10:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java
Line 39: private GlusterVolumeTaskStatusEntity fetchTaskStatusDetails() {
Line 40: VDSReturnValue returnValue =
Line 41:
runVdsCommand(VDSCommandType.GetGlusterVolumeRebalanceStatus,
Line 42: new
GlusterVolumeVDSParameters(getUpServerId(clusterId), volume.getName()));
Line 43:
The base class GlusterQueriesCommandBase throws a runtime exception while no up
servers in the method getUpServerId(). This would take care.
Line 44: // Set the volume re-balance start time
Line 45: GlusterVolumeTaskStatusEntity entity =
(GlusterVolumeTaskStatusEntity)returnValue.getReturnValue();
Line 46: List<Step> stepsList =
DbFacade.getInstance().getStepDao().getStepsByExternalId(volume.getAsyncTask().getStepId());
Line 47: if (stepsList != null && !stepsList.isEmpty()) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 281: GLUSTER_VOLUME_OPTIONS_RESET_ALL(4074),
Line 282: GLUSTER_HOST_UUID_NOT_FOUND(4075),
Line 283: GLUSTER_VOLUME_BRICK_ADDED(4076),
Line 284: GLUSTER_CLUSTER_SERVICE_STATUS_ADDED(4077),
Line 285: GLUSTER_VOLUME_TASK_STATUS_FAILED(4078),
Its not used currently. Would remove.
Earlier I thought of adding a command so added it.
Line 286:
Line 287: USER_FORCE_SELECTED_SPM(159),
Line 288: USER_VDS_RESTART(41),
Line 289: USER_FAILED_VDS_RESTART(107),
--
To view, visit http://gerrit.ovirt.org/18352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3704f750fafcf3546c5237a4dde67b5f85a691e4
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
