Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin, userportal: Avoid uncaught exceptions in
UiCommonEditorVisitor
......................................................................
webadmin, userportal: Avoid uncaught exceptions in UiCommonEditorVisitor
If a setter method is missing or has wrong argument type,
EditorContext.setInModel (generated) implementation will
look like this:
@Override public void setInModel(EDITED_TYPE data) {
throw new UnsupportedOperationException();
}
See AbstractEditorDriverGenerator:296 for details.
In above mentioned situation, EditorContext.canSetInModel
(generated) implementation will return false.
In short, we should always call canSetInModel before
attempting to call setInModel, otherwise uncaught
exception might break the application.
Change-Id: I4b7fc601bad9470eab7fbfa0e291f69f2cabae03
Signed-off-by: Vojtech Szocs <[email protected]>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18429
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b7fc601bad9470eab7fbfa0e291f69f2cabae03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
