Roy Golan has posted comments on this change.
Change subject: core: Add POWER 7 to the CPU list
......................................................................
Patch Set 4:
(3 comments)
see comments inline.
need REST maintainer to look at it as well
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
Line 41: }
Line 42: return null;
Line 43: }
Line 44:
Line 45: public static ArchitectureType GetArchitectureByCpuName(String
name, Version ver) {
getArch.. and not GetArch..
all new methods must adhere to java naming convetion. (and old one should be
renamed :) )
Line 46: final CpuFlagsManager cpuFlagsManager =
_managersDictionary.get(ver);
Line 47: if (cpuFlagsManager != null) {
Line 48: return cpuFlagsManager.GetArchitectureByCpuName(name);
Line 49: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ArchitectureType.java
Line 6:
Line 7: ppc64,
Line 8: x86_64,
Line 9: undefined;
Line 10:
what the purpose of undefined? is it to avoid using null?
Line 11: public static String nameOf(ArchitectureType architecture) {
Line 12: if (architecture == null) {
Line 13: return ArchitectureType.undefined.name();
Line 14: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ServerCpu.java
Line 61: public ArchitectureType getArchitecture() {
Line 62: return architectureType;
Line 63: }
Line 64:
Line 65: public void setArchitecture(ArchitectureType architectureType) {
is the setter necessary?
Line 66: this.architectureType = architectureType;
Line 67: }
--
To view, visit http://gerrit.ovirt.org/17853
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d63f0c66c2499f76b122d9c5cdbb7eebfe440e8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
