Lior Vernia has posted comments on this change. Change subject: webadmin: Copy VNIC profile configuration from template ......................................................................
Patch Set 2: (2 comments) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml Line 3 Line 4 Line 5 Line 6 Line 7 Yep. When there was no message set in this widget, this top border would appear as a short black line somewhere in the dialog. And now I've made it so that VNICs aren't created by default for a new VM, so it's possible that there won't be a message at all. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java Line 1016 Line 1017 Line 1018 Line 1019 Line 1020 It was, but I don't think it's right to create VNICs by default. If I had a template that didn't have any VNICs, then that probably means I don't want VMs created from it to have VNICs by default. If we want to have VNICs by default in the Blank template, then we should create them on the Blank template. -- To view, visit http://gerrit.ovirt.org/18460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffc7f38ce068a076fd66c245c178d9ff4813155a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
